search

SpacyNG / pwm

Automatically exported from code.google.com/p/pwm
0 stars 0 forks source link

New RTL hebrew (he) localization #92

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

Configuration:
1. modify the \webapps\pwm\WEB-INF\web.xml file and add the "he" to the value 
list:

value>en;;;cs;;;de;;;es;;;fr;;;it;;;nl;;;pl;;;pt;;;he</param-value>

2. duplicate the 
\webapps\pwm\WEB-INF\classes\password\pwm\config\Display.properties and rename 
it to Display_he.properties (at this point with some minor changes...)
3. duplicate the 
\webapps\pwm\WEB-INF\classes\password\pwm\config\Message.properties and rename 
it to Message_he.properties (at this point with some minor changes...)
4. duplicate the 
\webapps\pwm\WEB-INF\classes\password\pwm\error\PwmError.properties and rename 
it to PwmError_he.properties (at this point with some minor changes...)

At the browser:
1. http://my-site.com/pwm
2. Configuration Editor
3. Display-Display
4. no "he" (Hebrew) listed
5. browse to "change password" link- can't see the minor changes I made.

What version of PWM are you using?
v1.5.5

At this point I am not dealing with the RTL issue, I just want to see the 
Hebrew so I can translate&test what I am doing (in Hebrew, like other lag, 
sometimes we have  different meaning the same word, so I need to be able to 
check the relevant meaning at the time translating).

Original issue reported on code.google.com by dordorqwerty@gmail.com on 18 Jul 2011 at 8:17

GoogleCodeExporter commented 9 years ago 
Try using the country code "iw" instead of "he".  In my testing, the Java 
locale engine translates the browser code "he" to "iw".

Original comment by jrivard on 18 Jul 2011 at 1:30

GoogleCodeExporter commented 9 years ago 
svn revision 204/205 have support for rtl

Original comment by jrivard on 18 Jul 2011 at 1:58

GoogleCodeExporter commented 9 years ago 
Thanks! Now its work.

Original comment by dordorqwerty@gmail.com on 18 Jul 2011 at 2:42

GoogleCodeExporter commented 9 years ago 
I just finish to translate the main modules (main screen, change password, 
reset password, error message and messages) to Hebrew (Attached).
To test the configuration I changed the web.xml and add the .iw language to the 
"knownLocales", copy the 3 "_iw.properties" translated file to the current 
location and restart the tomcat.
I can see all Hebrew correct.
Some Q:
1.  To be able to see the Hebrew I need to use native2ascii format and I can't 
just type a Heb characters– why is that (same problem like issue 86…)?
2.  I try to translate the "Required Attributes" to Hebrew by using the "Add 
Locale" from the ConfigManager. When I type a Hebrew characters and save the 
configuration, I can see only Q marks "?????" – any idea?
3.  How can I test the RTL (I am not familiar with how to build from last 
revision) can you post an updated build for testing the RTL?

Original comment by dordorqwerty@gmail.com on 19 Jul 2011 at 4:00

Attachments:

GoogleCodeExporter commented 9 years ago 
Excellent!  Looks great!  I've added them so svn revision 207, and on the demo 
server. RTL seems to be working well as well.  Please review and approve.

Original comment by jrivard on 19 Jul 2011 at 8:24

GoogleCodeExporter commented 9 years ago 
I am not familiar with how to build from revision 207. just copy the files? Any 
instructions how to create new build?

Original comment by dordorqwerty@gmail.com on 20 Jul 2011 at 6:51

GoogleCodeExporter commented 9 years ago 
I've posted the latest build (1060) to the download page.  You can test with 
that.

Original comment by jrivard on 20 Jul 2011 at 12:02

GoogleCodeExporter commented 9 years ago 
The RTL works grate! the browser recognize the default language (Hebrew in my 
case) and show the Hebrew content as expected.
Still can't translate the "Required Attributes" to Hebrew by using the "Add 
Locale" from the ConfigManager. When I type a Hebrew characters and save the 
configuration, I can see only Q marks "?????" – any idea? 
In fact, you can't translate anything from the ConfigManager by using the "Add 
Local" option.
Still working to translate all other modules. I will upload a new translated 
files…

Thanks,
Doron.

Original comment by dordorqwerty@gmail.com on 20 Jul 2011 at 3:02

GoogleCodeExporter commented 9 years ago 
Update-
About translate from the ConfigManager by using the "Add Local" option- problem 
solved by writhing Hebrew word based on ISO 8859-8.

Original comment by dordorqwerty@gmail.com on 27 Jul 2011 at 8:03

GoogleCodeExporter commented 9 years ago 
I've been working on this issue, and opened a new issue to track it (issue 
100).  Please use this issue only for your next update to the hebrew 
localization files.

Original comment by jrivard on 27 Jul 2011 at 1:35

GoogleCodeExporter commented 9 years ago 
Cosmetics problems:
1.  The line separating between  user task and "Admin" align to the left (Screen 
shot attached). Should be align to the right.
2.  Is it possible to hide the "Admin" section from main menu? It's not relevant 
to the end user and its some kind of security issue.

Original comment by dordorqwerty@gmail.com on 31 Jul 2011 at 7:00

Attachments:

GoogleCodeExporter commented 9 years ago 
I think menno just checked in an enhancement for the configurable admin link 
(thanks menno!)...  As for the line, its actually in the center, its not rtl or 
ltr.  Its an html <hr/> element.  

But it does look kinda weird, I'll see if I can't come up with something better 
to separate that screen.

Will you be having updated _iw.properties files?  If not, I'd like to close out 
this issue..

Original comment by jrivard on 2 Aug 2011 at 8:54

GoogleCodeExporter commented 9 years ago 
New _iw files.

Original comment by dordorqwerty@gmail.com on 4 Aug 2011 at 8:50

Attachments:

GoogleCodeExporter commented 9 years ago 
Checked into svn revision 217.  Looks like PwmError hadn't changed since your 
last upload.  

I'm closing this issue for now.  If you further updates, please create a new 
issue.

Thanks again for your contribution!

Original comment by jrivard on 4 Aug 2011 at 2:12