search

Spade-Editor / Spade

Cross-platform raster graphics editor inspired by Paint.NET
GNU General Public License v3.0
41 stars 10 forks source link

Tools Dialog #34

Closed HeroesGrave closed 10 years ago

HeroesGrave commented 10 years ago

Create a dialog box for tools.

This will help #33 because we can move the quick colour chooser and tool info into there instead.

Gef4K commented 10 years ago

You can assign it to me, I'm currently working on it.

HeroesGrave commented 10 years ago

I can't assign you without setting you as a collaborator, and if I do that, you have write access to the repository, which I don't want.

Just commenting that you're working is enough.

Gef4K commented 10 years ago

Ok, no problem ! Is a first version with fixed ToolBox on the left of the JFrame acceptable ?

HeroesGrave commented 10 years ago

I would rather have a dialog working, but give me a screenshot and I'll see.

Gef4K commented 10 years ago

I've problem to restore floating JToolBar screen position at startup for now... image

HeroesGrave commented 10 years ago

And what does it look like as a dialog?

HeroesGrave commented 10 years ago

Anyway, open up a pull request, and we can discuss it further there.

HeroesGrave commented 10 years ago

Now we need a dialog.

@Gef4K: You happy to work on the dialog? You looked like you had something working before.

Gef4K commented 10 years ago

In fact the JToolBar can become floating with just a property change, and that works on my local. Actually I'm trying to restore the correct position and status of this JToolBar at startup (using UserPreferences), but the behaviour is different between floating and fixed initial status. Google will definitely give me a solution ;) Don't worry, that's funny to contribute !

HeroesGrave commented 10 years ago

Just make sure you pull in the changes I made before making another pull request.

The toolbox had a focus-stealing bug which I had to remove, so if you haven't updated, it will cause a conflict when I try to merge it.

Gef4K commented 10 years ago

Oups sorry ! I've made the checkout of the "dev" branch there is about a hour, apply my changes and "git pull" says me "Already up-to-date" and commited. Pull request is new for me, I will read more on the subject.

Edit : That's ok now I understood how it works !

Gef4K commented 10 years ago

Another test with a JDialog but width can't be smaller : image

HeroesGrave commented 10 years ago

Then make it 4 buttons wide. (or up to 6)

Gef4K commented 10 years ago

4 more possibilities with the actual ten buttons: 3 x 4 image 4 x 3 image 5 x 2 image 10 x 1 image Anyway, that could be adjust later...

HeroesGrave commented 10 years ago

For now, do 5-wide.