HSB colour picker glitches on monochrome colours

[HeroesGrave]

To reproduce:

• Slide the brightness slider to anything other than 0.
• Slide the saturation slider to anything other than 0.
• Slide the hue slide to any value other than red.
• Slide the brightness slider back down to 0.

or

• Slide the brightness slider to anything other than 0.
• Slide the saturation slider to anything other than 0.
• Slide the hue slide to any value other than red.
• Slide the saturation slider back down to 0.

The hue gets reset to red.

The state of the hue should stay the same while the saturation/brightness sliders are at 0.

[Longor1996]

The color-picker would have to store colors in HSB-A instead of RGB-A to do that. To be frankly, this can be completely ignored until a actual User of Paint.JAVA comes and says it needs to be fixed.

[HeroesGrave]

I think I might be able to do something...

[HeroesGrave]

What needs to be done is to store previous HSB values in a place that can be easily accessed, and then only change certain values when certain actions have been performed. (ie: Don't change the hue if the brightness/saturation slider was changed, but do change it for anything else)

I'll come back to this after 1.0

[BurntPizza]

Fixed, although probably not in the most elegant manner. I had each UI component set a static variable to a flag, and made the RGBtoHSB function not reset hue or saturation or both depending on what UI component was updating. I'll eventually refactor that whole class, it's a mess.

@HeroesGrave I'm done on the ColorChooser for a while now though, so you can merge it.

[BurntPizza]

@HeroesGrave Requesting close of this issue; see ef2121a above.

[HeroesGrave]

Oh, yes. Forgot about this.