Spade-Editor / Spade

Cross-platform raster graphics editor inspired by Paint.NET
GNU General Public License v3.0
41 stars 10 forks source link

Integrate WebLaF? #79

Closed HeroesGrave closed 9 years ago

HeroesGrave commented 10 years ago

WebLaF looks quite nice, and I had a go at using it for Paint.JAVA.

It worked well, and so then I tried making a plugin for it, but failed. For some reason it doesn't play well when loading it through reflection. And also dependency hell.

(The problem here might actually be to do with the plugin loading code, but I'm not entirely sure. I tried messing with a few different methods, but didn't see any change)

So, I'm putting this up here to see if we want to use it as the default LaF for Paint.JAVA.

Pros:

Cons:

While we're not having any issues with the file size, this is quite a big jump, and may require us to ditch the build/ directory and only release compiled versions for releases (which will be fine after 1.0). (Otherwise the repository size grows very quickly)

If we do end up using it, we also get the bonus of a lot of extra swing components that we don't have to write ourselves.

BurntPizza commented 10 years ago

It does look good, if we do it then builds should be handled by an actual build server, maybe https://travis-ci.org/ ?

There's also stuff like Substance

HeroesGrave commented 10 years ago

Why would we need a build server?

I meant using the Github Releases System.

It's probably not that bad. Dev versions will really only be used by people who have the tools to build them.

BurntPizza commented 10 years ago

It keeps the builds out of the repo. But I guess just not having distributed non-release builds is fine. Maybe just remove the build folder from the git index, and manually push it on releases?

HeroesGrave commented 9 years ago

This is completed, but not merged into master yet.

HeroesGrave commented 9 years ago

Merged into master.