Closed dreirund closed 1 year ago
Thanks for pointing out the issues, a bit later ill take a look at the one you've added to the aur and put it into the git repo after changing anything that needs changing (a quick view shows the arch is missing stuff like aarch64 but ill get around to changing that later in the day) Thanks again for the proposed changes and putting this in the aur.
Took me a while but i finally got around to it, thanks for the proposed changes ive added em in. Its basically a copy of your aur package but with the pkgver() just getting the version from the cargo.toml.
The current
PKGBUILD
in this repository has some issues:$pkgver
must be strongly monotoneously increasing with every git commit. Use thepkgver()
function for it. And I suggest that you put your main version (0.2.2
) somewhere where it can be parsed from the sources or/ and git repository, e.g. aversion.h
(or rust-alike file) which is used by the compilation process to bake in the version number into the binary, and which can be read out bypkgver()
provides=("pineflash=${pkgver}")
,conflicts=("pineflash")
.git
needs to be added tomakedepends
.gtk3
needs to be added as dependency.rust
download all it's dependencies within$srcdir
, and make that download already happen inprepare()
, so that no internet connection is needed inbuild()
orpackage()
.build()
.install
command preferably.GPLv2
is not a valid license under/usr/share/licenses/common/
. UseGPL2
.arch=('any')
is wrong. You need to list all supported processor architectures explicitly.A
PKGBUILD
which adresses most of this issues can be found → here.Regards!, and thanks for the software.