search

Spagett1 / pineflash

A tool to flash ironos to the pinecil soldering iron and possibly other pine64 devices in the future
Other
213 stars 12 forks source link

Added file picker dialog filter #55

Closed Quinten0508 closed 1 year ago

Quinten0508 commented 1 year ago

Simple change to add a filter when picking a custom firmware file following rfd's wiki. This kept annoying me while troubleshooting issue #/52, as I had to scroll through a few dozen unrelated files. Now only .bin and .dfu files (for V2 and V1 Pinecils respectively) should show up. You can change the description "Firmware files" to whatever you feel like makes more sense.

Tested on Windows 11 and MacOS Sonoma (arm64, not amd64), no issued found. ❗ Worth it to test on Linux (and MacOS amd64) before pulling.

Example of what it looks like on windows: image

Spagett1 commented 1 year ago

Thanks for the pull request however I've recently moved away from rfd to an option native to the app. This was to reduce dependancies and to allow the appimage to be built properly.

I do see the use for only showing certain filetypes though.

Quinten0508 commented 1 year ago

Gotcha, will close the PR then :)

Spagett1 commented 1 year ago

Yeah, it's something I'll investigate with the new file picker though