When opening the Events list screen, all the records are shown in pages of 10 records while the SPAGOBI.LOOKUP.numberRows parameter in the Configuration management screen states that it should be 20.
I found a ListEventsLogModule.java file that uses a GenericPaginator without looking up the value of the numberRows parameter.
An example of the lookup I found in ListBIObjectsModule.java
int numRows = 10;
try {
SingletonConfig spagoconfig = SingletonConfig.getInstance();
String lookupnumRows = spagoconfig.getConfigValue("SPAGOBI.LOOKUP.numberRows");
if (lookupnumRows != null) {
numRows = Integer.parseInt(lookupnumRows);
}
} catch (Exception e) {
numRows = 10;
logger.error("Error while recovering number rows for " + "lookup from configuration, usign default 10", e);
}
paginator.setPageSize(numRows);
Comments
Yvo Hooyberghs added a comment - 2014-10-20T13:52:35.828+0200
Updated ListEventsLogModule class
Yvo Hooyberghs added a comment - 2014-10-20T13:53:19.699+0200
Description of the changes and the result
Yvo Hooyberghs added a comment - 2014-10-20T13:57:23.814+0200
Hi,
I've added the lookup of the parameter SPAGOBI.LOOKUP.numberRows and refactored the while loop to avoid the creation of a lot of String objects (see attached ListEventsLogModule.java class).
The result of deploying this change is shown in the attached document (request_50018_issue_1909_changes.odt).
Details
People
Dates
Description
When opening the Events list screen, all the records are shown in pages of 10 records while the SPAGOBI.LOOKUP.numberRows parameter in the Configuration management screen states that it should be 20.
I found a ListEventsLogModule.java file that uses a GenericPaginator without looking up the value of the numberRows parameter.
An example of the lookup I found in ListBIObjectsModule.java int numRows = 10; try { SingletonConfig spagoconfig = SingletonConfig.getInstance(); String lookupnumRows = spagoconfig.getConfigValue("SPAGOBI.LOOKUP.numberRows"); if (lookupnumRows != null) { numRows = Integer.parseInt(lookupnumRows); } } catch (Exception e) { numRows = 10; logger.error("Error while recovering number rows for " + "lookup from configuration, usign default 10", e); } paginator.setPageSize(numRows);
Comments
Yvo Hooyberghs added a comment - 2014-10-20T13:52:35.828+0200
Updated ListEventsLogModule class
Yvo Hooyberghs added a comment - 2014-10-20T13:53:19.699+0200
Description of the changes and the result
Yvo Hooyberghs added a comment - 2014-10-20T13:57:23.814+0200
Hi,
I've added the lookup of the parameter SPAGOBI.LOOKUP.numberRows and refactored the while loop to avoid the creation of a lot of String objects (see attached ListEventsLogModule.java class).
The result of deploying this change is shown in the attached document (request_50018_issue_1909_changes.odt).
Kind regards