SpaiR / imgui-java

JNI based binding for Dear ImGui

MIT License

551 stars 90 forks source link

ImNodes::EditorContextGetPanning missing #152

Closed virusbear closed 1 year ago

virusbear commented 1 year ago

Description

This PR adds a missing binding for ImVec2 ImNodes::EditorContextGetPanning().

Type of change

[ ] Minor changes or tweaks (quality of life stuff)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

SpaiR commented 1 year ago

@virusbear Thanks for the contribution.

Y've did a small mistake about the way of how to get ImVec2 value. It's not possible to return it directly like you did. Please, do the same as in other parts of the code - provide destination ImVec2 and copy value inside of it.

https://github.com/SpaiR/imgui-java/pull/152/files#diff-2fda0565d60f78d6937827acc7d089798d7745dba830169c57138c2c0cb7db65R426-R429

virusbear commented 1 year ago

@SpaiR should be adjusted like this is done in other functions. Thank you for pointing this out.