SpankChain / general-state-channels

Spankchain PoC implementation of generalized state channels
https://spankchain.com/
GNU Affero General Public License v3.0
156 stars 24 forks source link

Potential typo in deployCTF? #2

Open yippee-ki-yay opened 6 years ago

yippee-ki-yay commented 6 years ago

https://github.com/SpankChain/general-state-channels/blob/master/contracts/ChannelRegistry.sol#L30

In the part of the code that should check the signatures of the bytecode to be deployed, the for loop is initialized at 2 and check if it's less than 2, so the for loop never enters.

nginnever commented 6 years ago

Yes good catch. And thanks for the eyes on the repo! Please feel free to fork and put in a small pull request to fix this if you would like a contribution on the project.

I plan to do some big overhauls to this in the coming days including...

yippee-ki-yay commented 6 years ago

OK cool, I'm glad this will be moving forward, I'm working currently at my company on utilizing state channels for games and developing and library around it and your research is very helpful.

The Merkalized state is a very interesting approach as logic for some games (other stuff as well) can get quite heavy and onchain resolution may be too costly. We've been thinking of some ways to split the logic up so you only need to handle a subset of computation.

"Discuss representing state as a pool of transactions that could be executed on chain. Form a merkle root of all transactions that lead to an agreed upon current state." - So basically a block of transactions? :D Not sure if I quite understood the last part but sounds interesting.

VoR0220 commented 6 years ago

@yippee-ki-yay essentially that's what he's describing is a block of transactions. The main takeaway is that they are externalized and the proof exists, and how you assemble to that proof is the key consideration.