search

SpankChain / general-state-channels

Spankchain PoC implementation of generalized state channels
https://spankchain.com/
GNU Affero General Public License v3.0
155 stars 24 forks source link

Truffle compile and migrate failed. #7

Open NFhbar opened 6 years ago

NFhbar commented 6 years ago

After forking, truffle compile and truffle migrate returned several warnings and errors. I fixed the critical ones and allowed for Travis CI and Coveralls continuous integration. Some styling changes also.

Several artifacts are also missing from root, so test files cannot pass. I commented out offending blocks to allow for proper build, see here:

https://github.com/NFhbar/general-state-channels/commit/1915947910627eb4eb8fcc4bf9e6aea3784018ab

nginnever commented 6 years ago

@NFhbar Awesome! Sorry to be such a moving target here and as you can see there have been a lot of edits to the repo in the past week. However things are forming and over the course of this month we should have a pretty stable code base.

Would you be willing to put in some PRs for these kind of improvements this month?

I will define a better road map and set up a gitter so we can discuss things like breaking changes.

NFhbar commented 6 years ago

@nginnever sounds good! Let me fork new master and check it out. I'll update with some easy PRs to start :)

NFhbar commented 6 years ago

https://github.com/SpankChain/general-state-channels/pull/11