search

Spanni26 / pyHPSU

Python Script to read and send commands to a Rotex HPSU
26 stars 15 forks source link

Firstpackage #36

Closed segaura closed 3 years ago

segaura commented 3 years ago

Closes #33

Hallo. This is the first package of my proposal, it includes only small fixes and small improvements, intended to be easy to review.

automatic mode cli options override working: if your .conf file says you want JSON output you can write -a -o MQTT and override it this solves issue 33

help label lookup through name not command: lookup is supposed to match label fields between commands_hpsu.json and commands_hpsu_XX.csv but code do not do this, it matches command field from the first and label field from the second ...everything works most of the time because command and label are the same but things broke up with command=t_screed_dayX and label=screed_dayX that do not match

.gitingnore vscode launch config added: this avoid committing my vscode launch.json, maybe in the future this can be shared because it contains a lot of launch configurations useful for debugging

command dictionary EN scrred -> screed :-) : cosmetic correction

command dictionary IT merged with EN version so all command are included, copy pasted every possible command description from one pdf user manual (FA ROTEX HPSU compact 4 - 11/2014) and 2 pdf installation service manuals (_ZB Daikin Altherma EHS(X/H) - setup . 03/2016 . 008.14 344 3900 and _ZB HPSU compact 2 / V0.92+ / 008.14 114 3900 12/2011)

deprecated function warning readfp(f) is deprecated and cause a warning: substituted with read_file(f) that is not deprecated

README.md missing influxdb dependency: influxdb output plugin needs python3-influxdb package, added

Spanni26 commented 3 years ago

Merged :)

Daniel

Am 10.02.2021 um 23:57 schrieb segaura:

Hallo. This is the first package of my proposal, it includes only small fixes and small improvements, intended to be easy to review.

automatic mode cli options override working: if your .conf file says you want JSON output you can write -a -o MQTT and override it /this solves issue 33 https://github.com/Spanni26/pyHPSU/issues/33/

help label lookup through name not command: lookup is supposed to match label fields between commands_hpsu.json and commands_hpsu_XX.csv but code do not do this, it matches command field from the first and label field from the second ...everything works most of the time because command and label are the same but things broke up with command=t_screed_dayX and label=screed_dayX that do not match

.gitingnore vscode launch config added: this avoid committing my vscode launch.json, maybe in the future this can be shared because it contains a lot of launch configurations useful for debugging

command dictionary EN scrred -> screed :-) : cosmetic correction

deprecated function warning readfp(f) is deprecated and cause a warning: substituted with read_file(f) that is not deprecated

README.md missing influxdb dependency: influxdb output plugin needs python3-influxdb package, added

    You can view, comment on, or merge this pull request online at:

https://github.com/Spanni26/pyHPSU/pull/36 https://github.com/Spanni26/pyHPSU/pull/36

    Commit Summary

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Spanni26/pyHPSU/pull/36, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2I5HEIENDQTQFNN7DFVHLS6MFNRANCNFSM4XN2HDDQ.