Spanni26 / pyHPSU

Python Script to read and send commands to a Rotex HPSU
26 stars 15 forks source link

t_room not working #40

Open segaura opened 3 years ago

segaura commented 3 years ago

Hallo. I saw in issue#18 that a commant t_room has been added to pyHPSU

        "t_room" :{
            "name" : "t_room",
            "command" : "81 00 FA 00 11 00 00",
            "id" : "190",
            "divisor" : "10",
            "writable" : "false",
            "unit" : "deg",
            "type" : "float"
        }

I notice that this is giving me error all the times. Reading issue#18 comments, my understanding is that the correct command is

31 00 FA 00 11 00 00

I don't have a Rocon U1 so I'm not sure reading this makes sense, anyway with this sequence I get this reading

2021-02-17 22:47:59,609 - DEBUG - CanPI, got:  32 10 FA 00 11 80 00
[{'name': 't_room', 'resp': '-3276.80', 'timestamp': 1613598479.611429}]

which is better than 45 retries and an error.

Is it correct to change 81 to 31?

Spanni26 commented 3 years ago

Hmmm, could be a typo. I don't know, how I've got this command.....

Am 17.02.2021 um 22:54 schrieb segaura:

Hallo. I saw in issue#18 https://github.com/Spanni26/pyHPSU/issues/18 that a commant |t_room| has been added to pyHPSU

|"t_room" :{ "name" : "t_room", "command" : "81 00 FA 00 11 00 00", "id" : "190", "divisor" : "10", "writable" : "false", "unit" : "deg", "type" : "float" } |

I notice that this is giving me error all the times. Reading issue#18 comments https://github.com/Spanni26/pyHPSU/issues/18#issuecomment-492200440, my understanding is that the correct command is

|31 00 FA 00 11 00 00|

I don't have a Rocon U1 so I'm not sure reading this makes sense, anyway with this sequence I get this reading

|2021-02-17 22:47:59,609 - DEBUG - CanPI, got: 32 10 FA 00 11 80 00 [{'name': 't_room', 'resp': '-3276.80', 'timestamp': 1613598479.611429}] |

which is better than 45 retries and an error.

Is it correct to change 81 to 31?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Spanni26/pyHPSU/issues/40, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2I5HB2YTA2N2BSVRWGXFTS7Q3K5ANCNFSM4XZEPRZA.

segaura commented 3 years ago

It seems you've been given some dump here

arizzi commented 1 year ago

it seems in the testing branch this has been changed to "31" instead of "81" but 31 is not correct, should rather be "61" The following works:

 "t_room" :{
                    "name" : "t_room",
                    "command" : "61 00 FA 00 11 00 00",
                    "id" : "190",
                    "divisor" : "10",
                    "writable" : "false",
                    "unit" : "deg",
                    "type" : "float"
            },