SparebankenVest / public-helm-charts

Public Helm charts provided by Sparebanken Vest
https://charts.spvapi.no
28 stars 51 forks source link

Remove unused 'ca.crt' key from 'Secret' resources #87

Closed tspearconquest closed 1 year ago

tspearconquest commented 1 year ago

Kubernetes doesn't support creation of a ca.crt file in kind: Secret resources with type: kubernetes.io/tls with kubectl, so there is no way to create this resource with kubectl create secret tls

Additionally, I was unable to find a reference to ca.crt anywhere in the controller, keyvault injector, or webhook code.

As per the links below, the webhook serving cert file and key, as well as the webhook CA cert file and key are all named tls.crt and tls.key, and I could not find any other mention where this file could have come from:

Signed-off-by: Thomas Spear tspear@conquestcyber.com

181192 commented 1 year ago

@tspearconquest Thank you! :relaxed: