search

SparebankenVest / public-helm-charts

Public Helm charts provided by Sparebanken Vest
https://charts.spvapi.no
28 stars 51 forks source link

Adds probes to the controler and liveness probe to the env-injector #99

Closed LennartTimmers closed 1 year ago

LennartTimmers commented 1 year ago

Solves: https://github.com/SparebankenVest/public-helm-charts/issues/97

This PR adds probes to the pods that run using the existing /healthz endpoint for both the env-injector and the controller. The env-injector already had a readiness probe so only the liveness probe was added, the controller didn't have either so I've added both.

Let me know if I need to make additional changes to comply with your pull request standards!

Kind regards,

Lennart

LennartTimmers commented 1 year ago

In addition this was tested on an AKS cluster on which the probes succeeded.

LennartTimmers commented 1 year ago

Can someone take a look at this PR?

181192 commented 1 year ago

@LennartTimmers Thank you very much :relaxed:

KenADev commented 1 year ago

@LennartTimmers The pods fail to start due to the probes failing when global.metrics.enabled is set to false, which is currently the default in values.yaml