SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
580 stars 353 forks source link

Person Tags AutoComplete #107

Closed azturner closed 11 years ago

azturner commented 11 years ago

The autocomplete drop-down functionality is not working for tags on the person profile page

azturner commented 11 years ago

Looked at this a bit, but looks like its a javascript issue somewhere or a missing class (tag-wrap). Assigning it to our javascript guy

JasonOffutt commented 11 years ago

@azturner, can you recall whether or not the tag autocomplete has ever worked?

azturner commented 11 years ago

Yes, it used to work. Not sure when it stopped working.

JasonOffutt commented 11 years ago

I'm noticing that autocomplete isn't working right on the person search if you search from the Person Details page. I had Nick confirm that he sees the issue too and that it's not something I just broke. :)

To replicate go to a person's record, then type something (e.g. - "John") into the person search in the upper left search box. Not sure if that's related or not.

Just to confirm, the tag autocomplete should give a typedown selection similar to the person search autcomplete (when it's working properly). Is that correct?

JasonOffutt commented 11 years ago

@azturner You were correct in that it was missing an <div class="tag-wrap"/> wrapper element in order to append the autocomplete results, however, the tag autcomplete is suffering from the same problem as the search autocomplete issue I mentioned above. I'll begin looking into that tomorrow.

JasonOffutt commented 11 years ago

I've got the TagList autcomplete working now in bug-jo-autocmoplete. I'm going to do a bit more testing before I merge it into develop. I've confirmed that it's not the TagList control causing the issue on the PersonDetails page.

@azturner Since this problem with autocomplete not working properly (in the TagList or the main search box) on the PersonDetails page is unrelated to the original bug, do you think it'd be best to spin off a new issue to track?

azturner commented 11 years ago

Yeah, that makes sense to create a different issue if they're not related

JasonOffutt commented 11 years ago

OK cool. Thanks!