Entity Attributes Attribute List Entity Type Changes

[smross]

Prerequisites

• [X] Put an X between the brackets on this line if you have done all of the following:
  • Can you reproduce the problem on a fresh install or the demo site ?
  • Did you include your Rock version number and client culture setting?
  • Did you %3Aissue+user%3ASparkDevNetwork+-repo%3ASparkDevNetwork%2FSlack perform a cursory search to see if your bug or enhancement is already reported?

Description

Filter Option of Entity Type does not obey the normal UI expectation for a "blank" value in the Entity Type picker (/page/193)

Steps to Reproduce

1. Login to Rock
2. Go to Admin Tools
3. Go to System Settings
4. Go to Entity Attributes
5. Select the drop-down for Filter Options
6. Change from an entity type in the list or None (Global Attributes) to the Blank setting (no text)
7. Select the Apply Filter button

Expected behavior:

When selecting the Blank entry the expectation is that ALL Entity Attributes would be listed, regardless of Entity Type or Category

Actual behavior:

Only the 'Entity Type' of 'None (Global Attributes)' is applied, apparently as a filter, even though none is selected

Versions

• Rock Version: 6.2, 6.3 Beta, 6.3, 6.4 Beta, 6.4
• Client Culture Setting: en-US

[cabal95]

Confirmed on our own install. @smross is correct, it appears that a blank filter is treated as None (Global Attributes) rather than show all.

[nairdo]

We've reviewed this change request. Since the Attributes block now has an entity type selector (if no Entity Type is set via the block's settings), it is not intended to show all attributes system wide without selecting the type.

Also, I recently fixed a bug in this block via https://github.com/SparkDevNetwork/Rock/commit/a437d3e386b6abb5f48c8183db59dcdc9379b85a so it will behave as designed in the 8.5 hotfix.

[smross]

Great idea on the selector. That's a better solution, and makes the block (and page) more usable anyways!