SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
579 stars 352 forks source link

Partially Completed SignNow Agreements showing as signed #2969

Closed chrisfunk closed 1 year ago

chrisfunk commented 6 years ago

Before completing your first issue we highly recommend reading this post on [https://www.snoyman.com/blog/2017/10/effective-ways-help-from-maintainers Effective Ways To Get Help from Maintainers ]().

Prerequisites

Description

When a user fills out a SignNow agreement/waiver on an iOS device, they have the option to save a partially completed form. Since this triggers an Updated callback event, Rock is seeing this as an agreement being signed. Rock is listening for the document.update event and if it is received with a document attached it is assuming that the document has been signed. Rock should instead be subscribing to and listening for the document.complete event instead.

Steps to Reproduce

  1. Setup a signature document with multiple fields in SignNow
  2. Configure the signature document in Rock
  3. Send yourself a signature request through Rock for that document
  4. Open SignNow email on iOS device and follow prompts to download SignNow application
  5. Complete one field on the agreement and click the save button (I think it is the arrow)
  6. Rock will receive the update event and will mark the agreement as signed.

Expected behavior:

Rock will not mark the agreement as being signed

Actual behavior:

Agreement is marked as being signed

Versions

jonedmiston commented 1 year ago

Closing as we no longer are supporting the Sign Now integration.