SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
577 stars 350 forks source link

Remove Bing as a geolocation provider #2978

Closed dcs619 closed 4 years ago

dcs619 commented 6 years ago

Description

Since v7 is released to the general public and includes free geocoding through SmartyStreets, please disable the Bing geolocation provider. Bing consistently strips apartment numbers and anything it doesn't recognize, rendering the address unusable.

Steps to Reproduce

  1. Add an address with street1 and street2
  2. Bing runs
  3. Address no longer has street2

Expected behavior:

Not have 30+ emails asking if I can restore addresses after Bing destroys them.

Actual behavior:

:frowning_face:

Versions

arranf commented 6 years ago

I disagree about removing this. SmartyStreet works effectively within the US only - removing Bing removes the only free international service. That said I do think Bing sucks (internationally as well) and should come with some kind of warning before enabling it.

EDIT: More broadly I think there should be some thoughts around how to do address validation in a safer manner. Addresses having fields irrevocably chewed up feels bad.

dcs619 commented 6 years ago

@arranf Can you confirm if Bing removes flat numbers when processing international addresses?

jonedmiston commented 6 years ago

It is deactivated by default.

dcs619 commented 6 years ago

@edmistj After researching this more, there's an issue with Rock's default settings and potentially the Bing geolocation code.

By comparison, SmartyStreets sets the Street1 and Street2 fields. Bing passes in Street1 and Street2, but only sets the Street1 field.

Because the Rock default (for the US) is to show a single Street field, users are entering "1 North Main St, Ste #9001" in Street1. Bing tries to geolocate that address, strips "Ste #9001" and returns "1 North Main St", which Rock then saves as Street1.

screenshot 2018-05-10 09 13 40

Proposed Changes:

1) Change the default setting for United States to always show Street2 2) Add a warning when enabling Bing that apartment/flat numbers could be removed 3) Add a warning in the documentation about enabling Bing 4) Update the Bing code to keep Street1 and Street2 separate

chrisfunk commented 6 years ago

I support keeping Bing as an option especially for International use, but I do believe that there is an issue with address standardization for US address. For example Southeast Christian's address is 920 Blankenbaker Pkwy, but Bing will update to KY Hwy 913 which is not acceptable by USPS.