SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
579 stars 352 forks source link

Statement Generator Account List Does not Honor Rock Account Order #4119

Closed rutledgek closed 2 years ago

rutledgek commented 4 years ago

Description

Submitted on Behalf of The Woodlands UMC

Steps to Reproduce

  1. Go to Financial Accounts and Note Sort Order
  2. Open Statement Generator
  3. View All Places that List Accounts
  4. Accounts are in Alphabetical Order rather than Order established in Rock

Expected behavior:

That the account order set in the Financial Accounts would be the default wherever financial accounts are shown/used including the Statement Generator

Actual behavior:

Account order is not respected in various places around Rock including the Statement Generator.

Versions

Rock Version: Rock McKinley 9.4 (1.9.4.1) Client Culture Setting: en-US

nairdo commented 4 years ago

@rutledgek We've attempted to reproduce this without success. We've asked the beta testers to attempt and they'll update here if they find anything.

smross commented 4 years ago

@rutledgek Can you provide some more insight into the accounts that you're seeing this happen for?

TL;DR I can't prove this is an issue we experience. I don't see how it could be consistent, as the Rock UI allows for parent/child relationships, and the statement generator UI doesn't have a mechanism for that in my case. i'm not sure what's expected..... we just live with it, and without showing the tree in Statement Generator, I don't know how it would be a 'mirror' of the main Rock UI

In our case we have a bit of a hierarchy for organization purposes. So, it's not really clear how the 'order' would translate, as the Statement Generator doesn't have a tree in use (like we do). This may or may not be confirmation, but here's what I experience:

Pictures showing what I experience...

Accounts | Rock RMS 2020-03-01 14-42-10

Screen Shot 2020-03-01 at 2 50 14 PM

My system I'm testing on info:

rutledgek commented 4 years ago

This is based on a client request. I am torn on which is better. This list appears to be global alphabetical which in makes sense. However, I can also see the value of a Parent -> Children -> subparent->children list. On the one hand, this would require knowledge of the tree structure in rock, on the other, the tree structure usually matches up with account groups. Tithe groups together, event groups together, campuses divided, etc so seeing them all grouped together as they are in the tree could be helpful.

smross commented 4 years ago

I think in a perfect world the UI in the Statement Generator would match Rock's UI. But honestly we only use the statement generator a small # of times a year (not daily). Therefore, I have no complaints. Does your client have feedback on how much of an impact this is having?

I disagree with you on the sorting. I don't see evidence that it is alpha sorted in the Statement Generator. I don't know how it's sorted, but my 2nd screenshot shows that a portion of my list is not alpha sorted

nairdo commented 2 years ago

Since the Statement Generator has gotten a major overhaul in recent releases, I'm pretty certain this issue has been resolved as of Rock v12.5. Nowadays, the accounts are selected during the creation of the 'Contribution Templates' under Financial Settings.

image

https://rock.rocksolidchurchdemo.com/finance/settings/contribution-templates/1 image

Then, during step 2 when running the Statement Generator app, you choose the template that has the configuration you want.

image