SignNow v11 redirect URL bug

markewampler commented 4 years ago

Prerequisites

Please don't just check the box unless you have done these things...

[ X] Put an X between the brackets on this line if you have done all of the following:
- Did you perform a search at https://github.com/issues?q=is%3Aissue+user%3ASparkDevNetwork+-repo%3ARock to see if your bug or enhancement is already reported?
- Can you reproduce the problem on a fresh install or the demo site?
- Did you include your Rock version number and client culture setting?

Description

In Rock v11 or in SignNow's API they changed a URL parameter. It wants redirect_uri where as Rock passes Redirect_Uri which fails. You get an error message instantly on load of the registration instance that has an inline signature with a sign now document that says the following:

{"errors":[{"code":131080,"message":"internal middleware error"}]}

Steps to Reproduce

Try and register for a Registration Instance that has an inline signature document attached to it
Get error message

Expected behavior:

You can sign a document as a part of your registration

Actual behavior:

Error message is instantly displayed on page load:

{"errors":[{"code":131080,"message":"internal middleware error"}]}

Versions

Rock Version: [v11]
Client Culture Setting: [EN-US]

markewampler commented 4 years ago

The fix to this bug is to apply a small change to the the block code in the 'RegistrationEntry.ascx.cs' file. Change line 780 from: Old Version: string redirectUrl = string.Format( "{0}?Redirect_Uri={1}", DigitalSignatureComponent.CookieInitializationUrl, HttpUtility.UrlEncode( returnUrl ) );

to by lowercasing the redirect_uri New Version: string redirectUrl = string.Format( "{0}?redirect_uri={1}", DigitalSignatureComponent.CookieInitializationUrl, HttpUtility.UrlEncode( returnUrl ) );

cabal95 commented 4 years ago

Confirmed, we have the same problem. We fixed our block the same way the other week but forgot to report it. :(

nairdo commented 4 years ago

Let me check... that might be the same fix (https://github.com/SparkDevNetwork/Rock/commit/114583e06da66b016b2fd084e5b0a55a8d68e9ff) we made for https://github.com/SparkDevNetwork/Rock/issues/4386. If so, this is likely a duplicate.

SparkDevNetwork / Rock