Photos do not save to Events when using Event Wizard - Githubissues

SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.

http://www.rockrms.com

574 stars 346 forks source link

Photos do not save to Events when using Event Wizard #4863

Closed JoshuaMaiorino closed 2 years ago

JoshuaMaiorino commented 2 years ago

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:
- Did you perform a search at https://github.com/issues?q=is%3Aissue+user%3ASparkDevNetwork+-repo%3ARock to see if your bug or enhancement is already reported?
- Can you reproduce the problem on a fresh install or the demo site?
- Did you include your Rock version number and client culture setting?

A Picture Is worth a Thousand Words

Did you know you you can simply copy and paste an image below? Please do that. It really helps us quickly understand the problem.

Description

When adding a new event using Event Wizard, photo's uploaded are not saving to the event. EventWizard_NewEvent_Photo

EventWizard_NewEvent_Detail

Steps to Reproduce

Go to Event Wizard
Created a New Event vs Selecting Existing
Upload a photo
Finish the Event Wizard
View the Event Details
No Photo will show.

Expected behavior:

Photos added through Event Wizard should to the Event

Actual behavior:

The Photo isn't saved

Versions

Rock Version: 12.4+
Client Culture Setting: en-us

JoshuaMaiorino commented 2 years ago

It looks like the issue is caused by this line: part of the code: https://github.com/SparkDevNetwork/Rock/blob/a0a7a3bf49f041334a50953ea2b8bab24b316b4c/RockWeb/Blocks/Event/EventRegistrationWizard.ascx.cs#L671-L674 The EventItem.PhotoId will always be null. I believe the Code should checking if the imgupPhoto.BinaryFileId is null.