SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
580 stars 353 forks source link

Gender Label Missing on Check-in New Family Adult Screen #5390

Closed stevekleinliquid closed 1 year ago

stevekleinliquid commented 1 year ago

Please go through all the tasks below

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

Screen Shot 2023-04-12 at 9 41 52 PM

Digging into the code, EditFamily.ascx, line 186:

<Rock:ButtonGroup ID="bgGender" runat="server" FormGroupCssClass="toggle-container" SelectedItemClass="btn btn-primary active" UnselectedItemClass="btn btn-default" Label="&nbsp;" Required="true" ValidationGroup="vgEditPerson" RequiredErrorMessage="Gender is required.">

Note that the field label is set to a blank, not "Gender".

Expected Behavior

The field label should be Gender.

Actual Behavior

The field label is blank.

Steps to Reproduce

Rock Version

14.1

Client Culture Setting

en-US

┆Attachments: image.png

nairdo commented 1 year ago

Hi @stevekleinliquid -- this was an intentional design decision back when the feature was first added. Although some fields moved around a bit since the original mockups, this same treatment was used on the Age Classification and Married Status fields as seen in this screenshot:

image

So, we won't consider this a bug to be fixed, but you can submit an idea over at the Ideas board at https://community.rockrms.com/Ideas

bmurphy-dev commented 1 year ago

I understand the original intent but think it's strange to leave a label off completely as display choices should be driven by styling, not just missing. Not everyone will use the default theme(s) available for this block, therefor not having a label all together is less convenient than having to hide one with styling in certain circumstances based on your design choices/needs. But, as mentioned by @nairdo this can be added as an Idea @stevekleinliquid

stevekleinliquid commented 1 year ago

Thanks @nairdo and @bmurphy-dev . I appreciate the feedback.