SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
572 stars 347 forks source link

Obsidian Registration Block Total does not match internal registration cost after discount applied. #5691

Closed rutledgek closed 8 months ago

rutledgek commented 9 months ago

Description

The Obsidian registration block total does not match the internal registration total when a discount is manually added to the registration. The Obsidian block shows a green success message that a discount was applied, but the discount is not reflected in the total. Registration-Berwyn-UMC-RegistrationCost Registration-Rock-RMS (1)

Actual Behavior

The total cost the obsidian block is showing for the registrar to pay is the full amount without the discount added manually.

Expected Behavior

The payment amount should be the same amount as shown on the internal registration

Steps to Reproduce

  1. Create a registration instance that has no cost but has fees. The fees should have a cost and allow for a quantity. Make sure that the fees have Discount Applies checked.
  2. Allow someone to register and select fees. In my instance they were 2 adults and 2 children for a total of 48.00.
  3. On the internal Rock Registration Edit page add a per registration discount of 8.00.
  4. Edit the registrant to ensure that discount applies is checked.
  5. Note that the total due on the registration is now 40.00.
  6. Send payment reminder email.
  7. When you click the payment reminder email, you will see a success alert that a discount of 8.00 was applied, but the total does not reflect that discount.

Issue Confirmation

Rock Version

16.0

Client Culture Setting

en-US

JDShuman commented 9 months ago

I tested this in our system (also running v16.0) and observed the same behavior.

nairdo commented 8 months ago

@JDShuman We've attempted to reproduce this in the upcoming v16.1 without success. We made a number of updates to this block in both v15.3 and v16.1, so we can ask the alpha testers to confirm if they are able to reproduce this in their v16.1 alpha.

JDShuman commented 8 months ago

Thanks, @nairdo! We are thankful for the effort you and your team continue to pour into these issues. Thanks for going the extra mile in asking the alpha testers to focus some attention here.

nairdo commented 8 months ago

@rutledgek When you say:

On the internal Rock Registration Edit page add a per registration discount of 8.00.

Do you mean put 8.00 into the "Discount Amount (per Registrant)" field?

Assuming this is the spot you are referring to, are you selecting a discount code or just applying a raw discount value without a code?

image

rutledgek commented 8 months ago

add a per registration discount of 8.00.

Do you mean put 8.00 into the "Discount Amount (per Registrant)" field?

Just adding 8.00 discount without a code.

kwishard88 commented 3 months ago

I'm testing this in 16.4 and still have an issue. When the discount code is assigned to the registration it isn't updating the Total Cost.

chead4 commented 3 months ago

@kwishard88 This issue has been proven difficult to reproduce. I have attempted to recreate on the demo site (v16.4) and when a discount code is applied either by the registrant when registering or internally by the admin the total cost is updating correctly. It would be greatly appreciated if you could provide steps to recreate (including screenshots) for the issue that you are experiencing and if you could recreate on the demo site that would be even more helpful.

rutledgek commented 3 months ago

I’m have not tried it yet, but the issue was when you placed a discount amount and not a discount code.

Get Outlook for iOShttps://aka.ms/o0ukef


From: Colleen Head @.> Sent: Wednesday, May 22, 2024 11:59:44 AM To: SparkDevNetwork/Rock @.> Cc: rutledgek @.>; Mention @.> Subject: Re: [SparkDevNetwork/Rock] Obsidian Registration Block Total does not match internal registration cost after discount applied. (Issue #5691)

@kwishard88https://github.com/kwishard88 This issue has been proven difficult to reproduce. I have attempted to recreate on the demo site (v16.4) and when a discount code is applied either by the registrant when registering or internally by the admin the total cost is updating correctly. It would be greatly appreciated if you could provide steps to recreate (including screenshots) for the issue that you are experiencing and if you could recreate on the demo site that would be even more helpful.

— Reply to this email directly, view it on GitHubhttps://github.com/SparkDevNetwork/Rock/issues/5691#issuecomment-2125151915, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF2ABHGJIGUXYH6AYKRTKODZDS6HBAVCNFSM6AAAAABALLBJTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRVGE2TCOJRGU. You are receiving this because you were mentioned.Message ID: @.***>

chead4 commented 2 months ago

@rutledgek Thanks for the feedback.

I've tried to reproduce by applying a discount amount and a discount code internally by an admin and the balance due and total cost amounts displayed are correct. I was able to recreate the issue in v16.2 but was unable to recreate in v16.3+.