Event Registration default Lava Template sends waitlist members 'Additional Confirmation Details' in confirmation email

[smross]

Description

The default lava template for waitlist members sends Event Registration Instance Additional Confirmation Details in the initial registration process, before they have been moved from the waitlist to the registrants.

I will be submitting a Pull Request to fix this.

Actual Behavior

Waitlist members receive additional confirmation information.

Expected Behavior

The default lava template for an event registration instance confirmation email should not send waitlist members additional confirmation details until they have been moved off of the waitlist.

Steps to Reproduce

1. Create an event registration that has waitlist functionality enabled, using the default communication settings.
2. Add registrants to reach the limit and put the registration instance into waitlist mode.
3. Register again (the additional registrant is now on the waitlist).
4. The registrar/registrant that is on the waitlist receives the 'additional confirmation details' information that is incorrect for waitlist recipients.

The confirmation email will send to them again when they are moved from the waitlist to the registration, so there is no reason to send them the additional confirmation details when they are on the waitlist.

Issue Confirmation

• [X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• [X] Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

14.4, 16.2

Client Culture Setting

en-US

[chead4]

@smross Hi Shawn - I am unable to recreate your issue in v16.2 and v16.3. Could you please supply screenshots of the issue that you are experiencing?

[smross]

@chead4 yes, I definitely will when I'm next able to. Hopefully this weekend.

[smross]

@chead4 Here's screenshots and an example process (sorry I missed that in the original):

Prerequisites:

• Email setup in the Rock instance
• An Event Registration Template using the default Communication Settings Lava Template for Confirmation Email; the default lava is set starting at https://github.com/SparkDevNetwork/Rock/blob/53fde76bf9376b9b7f5c7abb96b39caae03087a7/RockWeb/Blocks/Event/RegistrationTemplateDetail.ascx.cs#L52 and ending at https://github.com/SparkDevNetwork/Rock/blob/53fde76bf9376b9b7f5c7abb96b39caae03087a7/RockWeb/Blocks/Event/RegistrationTemplateDetail.ascx.cs#L137 with the problem being https://github.com/SparkDevNetwork/Rock/blob/53fde76bf9376b9b7f5c7abb96b39caae03087a7/RockWeb/Blocks/Event/RegistrationTemplateDetail.ascx.cs#L130
• Information in the Additional Confirmation Details (not blank)

Process with screenshots:

1. Create a new Registration Template, with waitlist enabled:

2. Accept the default Communication Settings

3. Populate the Registration Instance's Additional Confirmation Details:

4. Register enough people to get to the Maximum Attendees, such as 'Shawn Ross':

5. They receive a confirmation email, such as this one that includes the Addtional Confirmation Details:

6. Register an additional person so that they are on the waitlist, such as 'L.... Ross':

7. They receive a confirmation email that incorrectly includes the additional confirmation details, such as:

8. Move someone from the waitlist to be a registrant, and they will correctly receive the confirmation email which includes the additional confirmation details, such as: and

I was able to duplicate this bug in the following systems:

• Our Rock Production instance, running 14.3 (1.14.3.1 en-US)
• Our Rock testing instances, when we were running 16.2 and 16.2 Alpha (We also have history that this has occurred with 15.4, but I don't have prooftests for it, and won't be doing prooftests for 15.4).

[chead4]

@smross Thank you for providing all the additional screenshots Shawn. Very much appreciated!

[nairdo]

Just to clarify for anyone else looking at this issue. There is also a corresponding data-migration that will be in v16.4 as Rollup_20240315.cs to correct any existing RegistrationTemplates.