SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
580 stars 353 forks source link

Fixed an Issue Where Copying a Registration Template With Registration Attributes Would Break Registrations #5824

Closed Jon-Corey closed 7 months ago

Jon-Corey commented 7 months ago

Proposed Changes

Fixes a bug in the Registration Template Detail that caused incomplete attributes to be added to the attribute cache. These incomplete attributes cause the Obsidian Registration Entry block to throw a null reference exception whenever it tried to load a registration template's details.

This fixes that issue by removing attributes with an ID of 0 from the attribute cache right after they are added to the cache.

Fixes: #5823

Types of changes

What types of changes does your code introduce to Rock? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

Documentation

Migrations

Jon-Corey commented 7 months ago

Closing as no longer needed since this issue was fixed in https://github.com/SparkDevNetwork/Rock/commit/91caab36397ec1320606d22d2b2a2387acaf1943