SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
580 stars 353 forks source link

Fixed a Formatting on the Group History Timeline Lava Template #5827

Closed Jon-Corey closed 7 months ago

Jon-Corey commented 7 months ago

Proposed Changes

This fixes an issue in the Group History Timeline lava template where there would not be a space between the date and the year on section headings. This fixes that issue by appending a space to the beginning of the year. This means that the extra space is only added to the heading when the year is.

Before this fix:

GroupHistoryYearBefore

After this fix:

GroupHistoryYearAfter

Fixes: #5826

Types of changes

What types of changes does your code introduce to Rock? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

Documentation

Migrations

Jon-Corey commented 7 months ago

Closing due to my original commit not including a comma and a space (which is the standard way to format a date like this). New PR incoming.

Jon-Corey commented 7 months ago

This PR has been replaced by #5828. The new PR has the correct change.