SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
580 stars 353 forks source link

When Copying a Security Group the New Security Group Inherits the Permissions of the Original Security Group that was Copied #5862

Closed thejasonharvey closed 6 months ago

thejasonharvey commented 6 months ago

Description

When copying a group that is also set to be used as a security role. If the original group has been given access to parts of Rock, then the new group (the copy of the old one) will also be given those permissions upon creation.

Actual Behavior

I was working on updating our Org Chart to accommodate some restructuring. We use those groups as security roles as well. In the process of making the updates, I copied one group several times as its settings and naming convention made it convenient and preferable over starting from scratch. When I went to assign the newly created (copied) groups the access they needed in Rock, they all had the same access as the original group.

Expected Behavior

I would not expect the new groups to be automatically provided the same access as the original groups. Or, I would expect a notification that would let me know the new group would inherit those settings OR I would expect to be given the option (because I could see how that might be convenient under certain circumstances)

Steps to Reproduce

Screenshot 2024-05-07 145618

Issue Confirmation

Rock Version

16.3,16.4

Client Culture Setting

en-US

chead4 commented 6 months ago

@thejasonharvey Hi Jason Great timing! We have a feature enhancement to copying Groups that will be in v17.

Starting in v17, when the Copy icon is selected for a Group, a new Copy Group block will display. This block informs the user what items will be copied/not copied and let's you decide if you would like to Include Child Groups. If you would like, you can try this out now on the pre-alpha site.

I will be closing this issue at this time, but please let me know if you have any questions.

image

thejasonharvey commented 6 months ago

That'll work, thanks!