Group schedule reminders don't honor schedule end dates or exclusions. If an individual is scheduled, and then the schedule is edited to have an end date before the occurrence or an exclusion is added at the category (or individual schedule) level covering the occurrence, reminders are still sent. It seems like the logic checking for scheduling reminders doesn't consider the current state of the schedule at all and only looks at the attendance records.
Actual Behavior
Group schedule reminders if an individual has already been scheduled for an occurrence, even if the schedule has subsequently had an end date prior to the occurrence applied or an exclusion covering the occurrence added.
Expected Behavior
Group schedule reminders should honor exclusions and schedule end dates. If an individual is scheduled for an occurrence in the exclusion range or after the end of the schedule has passed, schedule reminders should not be sent.
Steps to Reproduce
This was reproduced on Rock Solid Demo by temporarily pointing the SMTP transport to a relay service.
Open the "Children's" group on Rock solid demo and schedule Ted Decker for an occurrence on the next weekend.
Edit the relevant schedule, and set an end date in the past (or set an exclusion).
Run the "Send Group Schedule Notifications" job. An email will be sent to Ted Decker for the occurrence that is either no longer happening because of the schedule end date or excluded.
Issue Confirmation
[X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
[X] Try to reproduce the problem on a fresh install or on the demo site.
Description
Group schedule reminders don't honor schedule end dates or exclusions. If an individual is scheduled, and then the schedule is edited to have an end date before the occurrence or an exclusion is added at the category (or individual schedule) level covering the occurrence, reminders are still sent. It seems like the logic checking for scheduling reminders doesn't consider the current state of the schedule at all and only looks at the attendance records.
Actual Behavior
Group schedule reminders if an individual has already been scheduled for an occurrence, even if the schedule has subsequently had an end date prior to the occurrence applied or an exclusion covering the occurrence added.
Expected Behavior
Group schedule reminders should honor exclusions and schedule end dates. If an individual is scheduled for an occurrence in the exclusion range or after the end of the schedule has passed, schedule reminders should not be sent.
Steps to Reproduce
This was reproduced on Rock Solid Demo by temporarily pointing the SMTP transport to a relay service.
Issue Confirmation
Rock Version
16.5
Client Culture Setting
en-US