SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
580 stars 353 forks source link

Default Rock Theme does not display custom Site Logo correctly when browser size is less than 768px wide (like a mobile browser) #5891

Closed stanalyst closed 5 months ago

stanalyst commented 5 months ago

Description

Setting up a site that uses the default Rock theme (like for an internal staff site) - and changing the "Site Logo" to a custom image. When the site is viewed on a browser that is less than 768px wide (like a mobile browser) - the logo does NOT display correctly - and it affects functionality (ability to easily click the logo to return to home page)

Actual Behavior

A picture explains it better than words... SiteLogo-Bad

Expected Behavior

Again a picture explains it better ... SiteLogo-Good

NOTE: We figured out how to adjust the styling for .navbar-brand-side .logo in _navbar.less so it displays correctly ... but felt it would be good if this were fixed in the default theme for the benefit of others.

Steps to Reproduce

Issue Confirmation

Rock Version

1.16.2.1

Client Culture Setting

en-US

sparkdevnetwork-service commented 5 months ago

@stanalyst We were not able to reproduce this on v16.5. Although it can be difficult to track down fixes that happened in the past, it does appear that this issue has been discovered and addressed since v16.2. Here is a screenshot showing v15.4 vs v16.5 for some of the related CSS styling that is involved: image

...where it looked like this: image

Please feel free to reopen this and include an example image if you still experience this in v16.5.