SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
577 stars 348 forks source link

Registration workflow exposes non-Public Registration Template attribute to public #5903

Closed ElimAdmin closed 3 months ago

ElimAdmin commented 3 months ago

Description

My understanding is that the 'Public' setting of an attribute determines whether it should or should not be displayed on the public web site. If this is correct, then: A Registration Attribute that is not ticked 'Public' should not display when the person registering is going through the Registration workflow. Current behaviour is that even if the attribute is not ticked Public, the attribute is still displayed. This means that Registration attributes cannot be used in private to manage the registration.


Registration attribute (entered on registration template) RegoAtt0


Registration attribute settings showing that the attribute is not public. RegoAtt5


Screen shot of registration workflow showing the attribute being displayed on the public web site, user not logged in. RegoAtt1


Attribute correctly displaying in the backend where I want to use it: on the Registration. RegoAtt3 RegoAtt4

Actual Behavior

The Public status of a Registration attribute is not respected on the public website when going through the Registration Workflow.

Expected Behavior

The Registration attribute NOT ticket Public, should not display in public.

Steps to Reproduce

  1. Go to demo site.
  2. Go to Tools > Event Registration
  3. Edit the template for Summer Camp
  4. Add a Registration Attribute, set Public to NO (not ticked)
  5. Change the end date of the Summer Camp instance to in the future to activate
  6. Go to https://rock.rocksolidchurchdemo.com/Registration?RegistrationInstanceId=1
  7. Enter registration details, and step through pages until you see... this:

RegoAtt6

  1. Verify that you see non Public Registration attribute in the public setting as part of the registration workflow.

Issue Confirmation

Rock Version

Version 16.5 16.5 (1.16.5.4),

Client Culture Setting

Client Culture Setting: en-NZ, Browser settings Language = English (New Zealand).

chead4 commented 3 months ago

@ElimAdmin Hi Ken - Please see the comment in #5553 for resolution of this issue.