In case you are submitting a non bug-fix-PR, we highly recommend you to engage in a PR discussion first.
There are many factors we consider before accepting a pull request. This includes:
Whether or not the Rock system you run is a standard, main-line build. If it is not, there is a lower chance we will accept your request since it may impact some other part of the system you don't regularly use.
Features that would be used by less than 80% of Rock organizations, or ones that don't match the goals of Rock.
With the PR discussion we can assess your proposed changes before you start working on it so that we can come up with the best possible approach to it. This may include:
Coming up with an alternate approach that does not involve changes to core.
Advising how your proposed solution be done in a different way that is more efficient and consistent with the rest of the system.
Have one of our core developers make the changes for you. This may be the case if the change involves intricate tasks like an EF migration or something similar.
Proposed Changes
Fixes: #5906
Types of changes
What types of changes does your code introduce to Rock?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality, which has been approved by the core team)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] This is a single-commit PR. (If not, please squash your commit and re-submit it.)
[x] I verified my PR does not include whitespace/formatting changes -- because if it does it will be closed without merging.
[ ] I have added any required unit tests or integration tests that prove my fix is effective or that my feature works
[ ] I have included updated language for the Rock Documentation (if appropriate)
Further comments
Documentation
Migrations
If your pull request requires a migration, please exclude the migration from the Rock.Migration project, but submit it with your pull request. Please add a note to your pull request that provides a heads up that a migration file is present.
Notice
In case you are submitting a non bug-fix-PR, we highly recommend you to engage in a PR discussion first.
There are many factors we consider before accepting a pull request. This includes:
With the PR discussion we can assess your proposed changes before you start working on it so that we can come up with the best possible approach to it. This may include:
Proposed Changes
Fixes: #5906
Types of changes
What types of changes does your code introduce to Rock? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Documentation
Migrations
If your pull request requires a migration, please exclude the migration from the Rock.Migration project, but submit it with your pull request. Please add a note to your pull request that provides a heads up that a migration file is present.