Rock Default Contribution Statement Template has deprecated CurrencySymbol Lava

[bmurphy-dev]

Description

The Rock Default statement template is still using the deprecated CurrencySymbol and not using the current | FormatAsCurrency filter. Most churches use this Rock Default template as a basis for their initial custom templates by copy/pasting the code here as a starting point. Here is the initial migration that inserted this new statement template. Correcting this Rock Default template will require a new migration with these code changes --> Here is a diff of the code needed in the migration What's kind of odd is that this was being deprecated the same time this new template system was being issue in v12.4 on the move to v13 according to the Technical Release Notes Changelog.

Currency - 4/15/2021 A new "OrganizationStandardCurrencyCode" global attribute has been implemented (and is used by the FormatAsCurrency Lava filter, as such usage of the older "CurrencySymbol" global attribute is now deprecated starting with v13. Use the CurrencyBox.Value property when setting the value of a currency (not the .Text property). It will also handle formatting the currency symbol as needed.

Actual Behavior

The amount fields rendered in the statements do not format correctly with , thousands separators. Example of fields missing the separators:

Expected Behavior

The lava in this Rock Default template be up to current standards and display currency values in a sensible manner.

Steps to Reproduce

• Go to Finance - Financial Settings - Contribution Templates
• Click on the Rock Default template row and then the Edit button
• Scroll down to the Report Template field
• See deprecated lava. Correcting this Rock Default template lava will require a new migration with these code changes --> Here is a diff of the code needed in the migration
• https://www.rocksolidchurchdemo.com/finance/settings/contribution-templates/1
• https://prealpha.rocksolidchurchdemo.com/finance/settings/contribution-templates/1

Issue Confirmation

• [X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• [X] Reproduced the problem on a fresh install or on the demo site.

Rock Version

v13.0 and up

Client Culture Setting

en-US

[bmurphy-dev]

I'm sure this also affects the actual currency symbol depending on an instance's culture settings but someone else would have to test that.

[PraveenMathew92]

We have updated the template in v16.7 of Rock as part of the commit: https://github.com/SparkDevNetwork/Rock/commit/caa324780c061fb9b286bb62b592192e723b299c