1st of Schedule Preference Auto-Scheduling Issues

[dataCollegechurch]

Description

Auto-scheduling individuals with a 1st of schedule preference (i.e. first Sunday) will incorrectly auto-scheduled after the 7th day in each calendar month. Instead of not being scheduled, individuals with a 1st of scheduling preference will be scheduled in the first remaining day (i.e. Sunday) available.

Actual Behavior

Individuals are auto-scheduled on days outside their preference.

Expected Behavior

Individuals are only scheduled on days matching their preference.

Steps to Reproduce

On the demo site complete the following after the first Sunday of the month but before the second Sunday passes: 1) Update Ted Deckers Preference to 1st and 3rd Week 2) Navigate to a page with the new obsidian group scheduler with the following settings Note: Our schedule is currently blank with no volunteers scheduled 3) Press the auto schedule button and see issue Note: Ted Decker was scheduled for the second and third Sunday of August. He should have only have been scheduled for the third Sunday in August. Months after August are being scheduled correctly.

Issue Confirmation

• [X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• [X] Reproduced the problem on a fresh install or on the demo site.

Rock Version

16.5

Client Culture Setting

en-US

[dataCollegechurch]

In my personal system I have also seen individuals with other schedule preferences i.e. (just 3rd or 4th Sunday) scheduled outside their preference in the scenario above. This may indicate that I have the nature of issue pegged wrong. Further testing would need to be completed to discern how the number of days into a month plays into this issue or if this is an issue at all. Perhaps the system is intentionally filling gaps. Exactly how auto schedule is intended to operate is somewhat opaque in the documentation.

[dataCollegechurch]

Grateful for you @jasonhendee, thank you for the thoroughness as you evaluated the underlying issue and thought through how to build a fix that wouldn't break other existing features

[jasonhendee]

Thank you for the kind words, Tony! This issue (and the other open iCalendar issue: Calendar Event Recurrences "by Specific Date" fail to Export) are certainly challenging us to think outside the box, especially since active development of iCal.NET - which Rock uses under the hood - appears to have stalled out in the last few years.

Thanks also for bringing this issue to our attention, and for providing an easily-reproducible example!