We're running into an issue on New Family Registration in Checkin where when adding adults the child role still shows:
This is specifically when dealing with custom relationship types. Namely, we use custom relationship types to differ between biological / adopted and foster children. The problem is that the role is displayed below the relationship if it's not the stock Child/Adult relationship regardless of whether or not the person is in the adult role:
https://github.com/SparkDevNetwork/Rock/blob/develop/RockWeb/Blocks/CheckIn/EditFamily.ascx.cs#L477.
We'd like a change to change this line to the following:
if ( familyPersonState.ChildRelationshipToAdult > 0 && _knownRelationshipLookup != null && !familyPersonState.IsAdult)
to support hiding the relationship for adult users to prevent confusion.
Actual Behavior
The relationship should be hidden, since the user is an adult, not a child.
Expected Behavior
Since this is not the stock relationship, it's displayed.
Steps to Reproduce
To replicate the issue, update the Weekly Service config to only have relationship roles other than Child/Adult (0), e.g.:
Open check-in on a kiosk that allows for new family registration
Add an adult user
See issue:
Issue Confirmation
[X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
[X] Reproduced the problem on a fresh install or on the demo site.
Description
Submitted on behalf of Trader's Point
We're running into an issue on New Family Registration in Checkin where when adding adults the child role still shows:
This is specifically when dealing with custom relationship types. Namely, we use custom relationship types to differ between biological / adopted and foster children. The problem is that the role is displayed below the relationship if it's not the stock Child/Adult relationship regardless of whether or not the person is in the adult role: https://github.com/SparkDevNetwork/Rock/blob/develop/RockWeb/Blocks/CheckIn/EditFamily.ascx.cs#L477.
We'd like a change to change this line to the following:
if ( familyPersonState.ChildRelationshipToAdult > 0 && _knownRelationshipLookup != null && !familyPersonState.IsAdult)to support hiding the relationship for adult users to prevent confusion.Actual Behavior
The relationship should be hidden, since the user is an adult, not a child.
Expected Behavior
Since this is not the stock relationship, it's displayed.
Steps to Reproduce
Issue Confirmation
Rock Version
16.4
Client Culture Setting
en-US