SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
579 stars 352 forks source link

Mediaplayer shortcode does not allow any other captions but English #6004

Closed kellygcastillo19 closed 1 month ago

kellygcastillo19 commented 1 month ago

Description

When enabling captions in the mediaplayer, English captions are automatically turned on, which is fine. The English captions work properly. When you go to select a different language for captions (Spanish in our case), the mediaplayer fails to select the language and proceeds to disable captions.

Actual Behavior

When Spanish captions is selected, captions are disabled. selectSpanishCaptions captionsDisabled

Expected Behavior

Spanish captions are allowed to be clicked on. When clicked on, the Spanish captions are enabled.

Steps to Reproduce

This requires the HLS video file link from Vimeo and a lava template with the mediaplayer shortcode. The lava template is used for a Content Channel Item View block. The HLS link is pulled from a content channel item attribute called "HLS Video", and assigned to variable "video".

We have the shortcode configured like this: {% assign video = Item | Attribute:'HLSVideo','RawValue' %} {[ mediaplayer src:'{{ video }}' autoplay:'true' muted:'true' ]}{[ endmediaplayer ]}

The HLS video link displays the correct video, the video plays, the controls show up as desired, and all controls work properly except the control to select a caption language other than English.

Issue Confirmation

Rock Version

Rock McKinley 15.5 (1.15.5.1)

Client Culture Setting

en-US

sparkdevnetwork-service commented 1 month ago

@kellygcastillo19 Thanks for the heads up - looking into this.

nlabarbera commented 1 month ago

Hey @kellygcastillo19 - again, thanks for reporting this!

Wanted to let you know that we have shipped this fix with v16.7 🚀