SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
579 stars 353 forks source link

Person Entry Form does not respect Active Campus field #6006

Closed randyaufrecht closed 3 weeks ago

randyaufrecht commented 1 month ago

Description

When viewing a workflow created via workflow configuration or form builder, and showing the Person Entry Form and wanting to display the campus selector, inactive campuses are being displayed. Screenshot 2024-09-11 154607

Actual Behavior

When you use either form builder or Workflow Person Entry Form, the "Show Campus" selector gives you the ability to show campuses, but the campuses that show are all campuses including inactive campuses. Choosing a filter of Campus Type or Campus Status give the same results showing inactive campuses if they are also included in the respective filter. Screenshot 2024-09-11 154607

Screenshot 2024-09-11 154630

Screenshot 2024-09-11 155057

Expected Behavior

When someone wants to show campuses on a form Inactive campuses should be not displayed by default. If they do need to be displayed, a checkbox should be available "Show Inactive" available so inactive campuses can be seen. The checkbox should be turned off by Default.

Steps to Reproduce

Issue Confirmation

Rock Version

1.16.4

Client Culture Setting

en-US

chead4 commented 1 month ago

@randyaufrecht Hi Randy Thanks for reaching out. After reviewing, I noticed that the Workflow Entry Form, includes a 'Campus Status' field which helps determine which campuses are available for selection.

I'll be closing this issue for now, but if it doesn't resolve your issue, feel free to reach out and I'll be happy to reopen it.

image

randyaufrecht commented 1 month ago

Colleen, This does not solve the problem. This requires all staff who can build forms to know how to use that field and they can't choose more than one status. What if the form needs all Pending and all Open Campuses? If you look at the field type of Campus in the form builder, it does allow for removing Inactive campuses and so does the field type of Campus in a Workflow, therefore, the same field should be available on the Person Entry form.

On Wed, Sep 11, 2024 at 5:16 PM Colleen Head @.***> wrote:

@randyaufrecht https://github.com/randyaufrecht Hi Randy Thanks for reaching out. After reviewing, I noticed that the Workflow Entry Form, includes a 'Campus Status' field which helps determine which campuses are available for selection.

I'll be closing this issue for now, but if it doesn't resolve your issue, feel free to reach out and I'll be happy to reopen it.

image.png (view on web) https://github.com/user-attachments/assets/23246bb0-926e-49a5-b2c6-b406e8b491cd

— Reply to this email directly, view it on GitHub https://github.com/SparkDevNetwork/Rock/issues/6006#issuecomment-2344796585, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCRXNDRUFZF7XN42OQ374ZDZWC6MVAVCNFSM6AAAAABOB2Y6WKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUG44TMNJYGU . You are receiving this because you were mentioned.Message ID: @.***>

--

Randy Aufrecht

Rock Developer

P • (210) 496-5096 x1017

A • 2477 N. Loop 1604 E. SATX 78232

https://www.facebook.com/cbcsocial/https://www.instagram.com/cbcsocial/https://www.youtube.com/channel/UCm2bTbosRvfyDNVb09vMcnA

https://www.communitybible.com/

sparkdevnetwork-service commented 1 month ago

@randyaufrecht Hi Randy thank you for the additional feedback. I'll be reopening this issue, and you should expect a fix in an upcoming version.