Captcha Rendering Twice

tikool17 commented 2 months ago

Description

We recently enabled captcha via Cloudflare Turnstile on our site. On our giving page (Transaction Entry v2) we then noticed page reloads and errors in the browser console about turnstile being rendered twice. We were able to reproduce this on the demo site as well.

There is some discussion of a similar issue on Cloudflare's forums here https://community.cloudflare.com/t/turnstile-ready-firing-twice/690171

Actual Behavior

-Captcha is rendered twice.

-There's errors in the browser console.

-also this console error reported in rocketchat "112 warnings for Cloudflare Challenge cookies about how "Third-party cookie will be blocked in future Chrome versions as part of Privacy Sandbox."

-There also seems to be a page reload a a few seconds after each page load where the Rock loading icon appears.

Expected Behavior

Captcha should only render once. Page reloads shouldn't happen.

Steps to Reproduce

On the demo site, enable captcha support. You can use Cloudflare's dummy keys for turnstile https://developers.cloudflare.com/turnstile/troubleshooting/testing/
Go to a block that uses captcha to see the error. (I tested on Utility Payment and Transaction Entry V2 on the demo site)

Issue Confirmation

[X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
[X] Reproduced the problem on a fresh install or on the demo site.

Rock Version

16.6, 16.5

Client Culture Setting

en-us

chead4 commented 2 months ago

@tikool17 H iChase - After reviewing the issue, I'm happy to share that the issue has been resolved in v16.7 with [commit]. Since the issue is resolved, I will go ahead and close the issue.

dataCollegechurch commented 2 months ago

@chead4 - should this item be tagged with some sort of fixed in 16.7 tag?

chead4 commented 2 months ago

@dataCollegechurch Thanks for reaching out Tony, I have added the Fixed in v16.7 tag.

SparkDevNetwork / Rock