When looking at the detail for a Persisted Dataset in the new Obsidian PersistedDatasetDetail block, the Last Refresh label is always a warning label, regardless of when it last refreshed. I checked the code in the repo, and it looks like it is hardcoded that way.
It's a small detail, but as a developer of persisted datasets this feels misleading. When I see a warning label, I naturally think there's a potential issue I need to be aware of or take a look at. The language is also confusing, as it says "Not Run Since: ", even if it just ran. The language and label itself combine to make me think the persisted dataset isn't running, when in fact it is. I just have to use the date/time to know it is.
Actual Behavior
The Last Refresh label on the Persisted Dataset Detail block confusingly shows a warning label all the time. It also confusingly says "Not Run Since:" which makes me think it hasn't refreshed recently.
Expected Behavior
I would expect the Last Refresh label to be dynamic based on the time since last refresh, similarly to how the Time to Refresh label works. If the Last Refresh of the dataset has been within the last 6-12 hours, I would expect it to show a success label with language like "Last Run: ". If it has been longer than that, I would expect the "Not Run Since" language with a warning label. (Honestly, I'd expect that if it hasn't run within the defined schedule that it would show warning, but that is far more complex. i.e. if the refresh interval is every 4 hours and it last run 6 hours ago, there's an issue)
Steps to Reproduce
Go to the Persisted Datasets on the Prealpha site (Admin Tools > Settings > Persisted Datasets)
Manually refresh the dataset for Volunteer Generosity
Click on the Volunteer Generosity dataset to view its detail
Notice that even though you just refreshed the dataset, it still shows a warning label and "Not Run Since"
Issue Confirmation
[X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
[X] Reproduced the problem on a fresh install or on the demo site.
Description
When looking at the detail for a Persisted Dataset in the new Obsidian PersistedDatasetDetail block, the Last Refresh label is always a warning label, regardless of when it last refreshed. I checked the code in the repo, and it looks like it is hardcoded that way.
It's a small detail, but as a developer of persisted datasets this feels misleading. When I see a warning label, I naturally think there's a potential issue I need to be aware of or take a look at. The language is also confusing, as it says "Not Run Since: ", even if it just ran. The language and label itself combine to make me think the persisted dataset isn't running, when in fact it is. I just have to use the date/time to know it is.
Actual Behavior
The Last Refresh label on the Persisted Dataset Detail block confusingly shows a warning label all the time. It also confusingly says "Not Run Since:" which makes me think it hasn't refreshed recently.
Expected Behavior
I would expect the Last Refresh label to be dynamic based on the time since last refresh, similarly to how the Time to Refresh label works. If the Last Refresh of the dataset has been within the last 6-12 hours, I would expect it to show a success label with language like "Last Run: ". If it has been longer than that, I would expect the "Not Run Since" language with a warning label. (Honestly, I'd expect that if it hasn't run within the defined schedule that it would show warning, but that is far more complex. i.e. if the refresh interval is every 4 hours and it last run 6 hours ago, there's an issue)
Steps to Reproduce
Issue Confirmation
Rock Version
Rock McKinley 17.0 (1.17.0.29)
Client Culture Setting
en-US