[1.16.7.2 Alpha] Nextgen Checkin Missing Critical "Prioritize Grade" Feature

JimMichael commented 3 weeks ago

Description

The existing ("legacy") check-in has a core-supported feature that "prioritizes grade" for a child checking-in who has an age that would quality them for one room, but a grade that would qualify them for another. This feature appears to be missing in Nextgen Check-in.

Actual Behavior

Nextgen check-in presents both areas to choose, because it seems to have no "prioritize grade" option, which (in legacy check-in) is a supported via an alternate FilterGroupsByGradeAndAge Workflow action detailed here in the check-in documentation https://community.rockrms.com/documentation/bookcontent/10/307#filtergroupsbygradeandage

This is what legacy check-in looks like for a child that qualifies for PreK and Kindergarten, using the FilteGroupsByGradeAndAge action with Prioritize Grade option set to Yes:

This is what Nextgen Check-in does for the same child, because there is no similar "prioritze grade" option (at least not that I could find in either block settings or checkin config panels)

Expected Behavior

There would be a mechanism in Nextgen Check-in to prioritize grade when a person meets criteria for different areas based on their age and grade.

Steps to Reproduce

Configure Nextgen check-in and look for an option to "prioritize grade", but you can't find it (unless I'm blind!) This would have to be implemented as either a block setting in the new Checkin Kiosk block, or in Check-In configuration itself, because (obviously) there is no longer a workflow driving Nextgen, which is where this alternate action currently lives.

Issue Confirmation

[X] Perform a search on the Github Issues to see if your bug or enhancement is already reported.
[X] Reproduced the problem on a fresh install or on the demo site.

Rock Version

1.16.7.2

Client Culture Setting

en-US

nairdo commented 3 weeks ago

@JimMichael As we're sorting out the logic in that workflow action, we have a nuanced question about your usage of that action that can be easily answered via a screenshot. Can you attach a screenshot showing your configuration of the replacement FilteGroupsByGradeAndAge workflow action (just like one shown in the documentation):

JimMichael commented 3 weeks ago

Here ya go!

adamhann commented 2 weeks ago

I can confirm this issue as well. It was one of the first things we checked!

jonedmiston commented 2 weeks ago

This is being worked on now and the fix will be in the beta for v16.7.

cabal95 commented 2 weeks ago

I forgot to tag this issue in the commit, it has been resolved in https://github.com/SparkDevNetwork/Rock/commit/d73b2096c662ec06d59542b98b87228749e5a288

Please note that the way to configure this is slightly different than it was in v1 and we are working on the documentation for that now.

nairdo commented 1 week ago

@JimMichael We're in the final stages of updating the new Next-Gen Check-in manual, but this particular feature is documented like this at the moment:

adamhann commented 1 week ago

@nairdo @jonedmiston We just tested the update that now allows you to prioritize grade over age. Thank you! I like the intentionality that you put into that setting. One note, if you select a config to prioritize grade over age, it now completely removs any groups that are check-in by data view as well. Is that intentional? It seems that Check-in by data view groups should be excluded by this setting. I can open up another issue, I just wanted to make sure it wasn't intentional.

cabal95 commented 1 week ago

Hi @adamhann. That was intentional so that it matches with the old "legacy" check-in behavior. The logic it used was that, when enabled, if you matched a group by grade, it would remove all other groups that were not matched by grade; even if they were filtered by something other than grade and age.

If that feels like it would be undesired behavior please let us know!

JimMichael commented 1 week ago

@nairdo I only just saw this, thanks for the link! (For some reason Github is no longer sending me emails for some issues).

Anyway, it looks good to me! I did notice a tiny typo, if someone wants to fix it

nairdo commented 1 week ago

@adamhann Daniel was able to isolate your particular edge-case so that 4518f1a commit is his fix for that. This will also be in in the upcoming 1.16.7.3 alpha release.

For the record, here's how I had mine configured when I was able to reproduce the issue and the fix: