SparkDevNetwork / Rock

An open source CMS, Relationship Management System (RMS) and Church Management System (ChMS) all rolled into one.
http://www.rockrms.com
574 stars 347 forks source link

Incorrect Date/Time on items from Check Scanner App #956

Closed bwitting closed 9 years ago

bwitting commented 9 years ago

On McKinley 3.1:

Some dates/times on the Check Scanner app don't match what is in the Rock Batch info. For example, these items were scanned on 4/1:

2015-04-16 16_50_09-rock rms - check scanner

But the Transaction date in Rock shows 3/13:

2015-04-16 16_50_19-financial batch detail _ rock rms

Maybe this is a timezone issue? On many transactions, the time is midnight, but in the example above, it is 3 hours behind (although we're in EST, UTC-4)

This isn't a problem with every batch, just some. Here is one where the date is correct:

2015-04-16 16_58_11-rock rms - check scanner

2015-04-16 16_56_58-financial batch detail _ rock rms

MikeDPeterson commented 9 years ago

The 3 hour difference that you found is due to a bug, which is fixed in https://github.com/SparkDevNetwork/Rock/commit/5ae46e52d062594c9c4424d65795adf04a4ce451

Besides that, the Transaction DateTime and Scanned DateTime for scanned item can be a little confusing, so we'll update the documentation to make that more clear. Here is how it works

The Scanned Date/Time that you see in the Scanner Grid is the Date/Time that the scanned item was uploaded. The Transaction Date/Time of each scanned transaction is determined by the Batch Date at the time of the scan. Note that if the Batch Date was changed after some checks were already uploaded, the previously scanned checks would have the old Batch Date and the new scanned checks with have the new Batch Date.

bwitting commented 9 years ago

Great, thanks for the info @mikepetersonccv! I seem to be good at finding fringe cases...