search

SparkNFT / SparkLink

The SparkNFT fontend repository.
3 stars 7 forks source link

We are using bigint type to strore Price and other value whose value area is 2^256 #176

Open Erreth-Akbe opened 2 years ago

Erreth-Akbe commented 2 years ago

What's going wrong?

We are using bigint type to strore Price and other value whose value area is 2^256

How to reproduce?

Nothing happens now, but some token like $SHIB may exceed 2^64*10^18

Expected behavior

I think using BigNumber type is a good solution.

Context

refactor branch.

Erreth-Akbe commented 2 years ago

@SantanaSP Should concern this problem in refector project.