search

SparkPost / elixir-sparkpost

SparkPost client library for Elixir https://developers.sparkpost.com
Apache License 2.0
44 stars 13 forks source link

HTTPoison Conversion #16

Closed DavidAntaramian closed 8 years ago

DavidAntaramian commented 8 years ago

This addresses #12, which thankfully was very isolated. The largest factor of the changes was making sure callers of SparkPost.Endpoint.request/3 were updated to call SparkPost.Endpoint.request/5 correctly. request/5 is modeled to be identical to the underlying HTTPoison.request that it calls.

The majority of the changes to tests were handled by updating the mocks, but as I mentioned in #13, I think these tests are very fragile since they are not testing the true functionality of the module. That being said, I've done some manual testing which works. :ok_hand:

I did make a small change to the config file layout which uses the typical tiered layout.

@ewandennis @richleland

princemaple commented 8 years ago

hello?

ewandennis commented 8 years ago

My my. This PR has been open waaay too long for which I apologise.

@DavidAntaramian - would you mind bumping httpoison to v0.9.0 and we'll get this merged down?

I'd also love a chat about test strategy at some point. I'll come find you on Slack...

DavidAntaramian commented 8 years ago

@ewandennis I should be able to find some time this week. Will do!

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 287d1a3af383bb68975879d82ffb596f3ea561a7 on DavidAntaramian:features/12-use-httpoison into 270ff6d38bb73f869aadbf104dc8223593170d5b on SparkPost:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b1eb97098d9915808f9b2a83451049293501bddd on DavidAntaramian:features/12-use-httpoison into 270ff6d38bb73f869aadbf104dc8223593170d5b on SparkPost:master.

princemaple commented 8 years ago

@ewandennis could this be merged now?