SparkPost / elixir-sparkpost

SparkPost client library for Elixir https://developers.sparkpost.com
Apache License 2.0
44 stars 13 forks source link

Issue 31 - Add template preview API #32

Closed asgoel closed 7 years ago

asgoel commented 7 years ago

fixes #31.

This is all I currently need but if I find time I can add the other template APIs as well.

Unrelated but I noticed that travis is still using 1.2? Can we bump to 1.4 or are there things blocking? Seemed to work fine on my machine

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 08720cf49de8aa86c5e4042f2f13c2411b726495 on asgoel:ISSUE-31 into db61e126fdc4a935f418ca3212b156a38fcf58d5 on SparkPost:master.

asgoel commented 7 years ago

good catch @ewandennis - didn't even notice that Content.Inline was the same. I've moved the code over, let me know what you think.

Any chance we can get 1.4 on travis too? That's where those warnings were coming from

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f3e209c6dd138fe49b0bc1300aebfaaaa84e33ef on asgoel:ISSUE-31 into db61e126fdc4a935f418ca3212b156a38fcf58d5 on SparkPost:master.

ewandennis commented 7 years ago

Ideal @asgoel, thanks. Those updates look perfect. I pushed a Travis config update yesterday to test against 1.2, 1.3 and 1.4.

I'll merge your PR now and we should see Travis results for all 3 versions.