search

SparkPost / elixir-sparkpost

SparkPost client library for Elixir https://developers.sparkpost.com
Apache License 2.0
44 stars 13 forks source link

Suppression list search #37

Closed asgoel closed 7 years ago

asgoel commented 7 years ago

@ewandennis I haven't added the tests yet, but wanted to make sure I interpreted this particular query properly, since its a bit different than the others. I had to go ahead and modify the behavior of Endpoint.Response since the suppression list search query returns more than just a results field. Let me know if I've done this properly and I'll go ahead and add the tests. Thanks!

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-5.1%) to 94.898% when pulling 3040954a53e20ca893488241b7300c0875cb1acb on asgoel:suppression_list_search into 8a6d29aed3e97defd08c690cf8c97b5be9562092 on SparkPost:master.

asgoel commented 7 years ago

@ewandennis made requested changes - mind taking a look?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0bc8ba47a67d0e81bd5f87e208ca0ae9583cd04a on asgoel:suppression_list_search into 8a6d29aed3e97defd08c690cf8c97b5be9562092 on SparkPost:master.

ewandennis commented 7 years ago

lgtm. I was a little concerned about explicitly converting each suppression list entry into a %SparkPost.SuppressionList.ListEntry but I got over it after a quick timing comparison :)

This is ready to merge from my perspective. Thanks again @asgoel!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 17f5d3fbdf508da14622e3262ef7a2b01a803016 on asgoel:suppression_list_search into 8a6d29aed3e97defd08c690cf8c97b5be9562092 on SparkPost:master.

asgoel commented 7 years ago

@ewandennis can we get this one merged in? have another waiting on top of this :)

ewandennis commented 7 years ago

@asgoel More you say? I'll wait to cut the next release then ;)