search

SparkPost / elixir-sparkpost

SparkPost client library for Elixir https://developers.sparkpost.com
Apache License 2.0
44 stars 13 forks source link

Suppression list Insert and Delete #40

Closed asgoel closed 7 years ago

asgoel commented 7 years ago

@ewandennis added ability to insert/update or delete a single suppression list entry.

Also had to add one more error check to the endpoint response parser to handle normal HTTPoison errors (such as request timeouts).

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9035124ee94dc116c3e528afb1a73f252562489c on asgoel:suppression_list_delete_insert into e20f6dacef3bd3ce6e39273996e59659f6d913d9 on SparkPost:master.

asgoel commented 7 years ago

@ewandennis started the migration over to the idiomatic {:ok | :error, resp} tuples. let me know thoughts

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d8efa11823225ab1f62406760221c84191d66610 on asgoel:suppression_list_delete_insert into e20f6dacef3bd3ce6e39273996e59659f6d913d9 on SparkPost:master.

ewandennis commented 7 years ago

Sorry for the delay on this. I'm going to merge, do a little cleanup elsewhere and cut a release. Thanks as ever @asgoel !