search

SparkPost / heml

HEML is an open source markup language for building responsive email.
https://heml.io
MIT License
4.33k stars 157 forks source link

Button padding instead of anchor padding #71

Open drapisarda opened 6 years ago

drapisarda commented 6 years ago

Hello to all! Using padding for the button element, I noticed it results in padding for the table data cell containing the anchor element, instead of padding for the anchor element. This means that the clickable area will be the anchor text, not the whole viewable button area. <button class="button--primary button--inverted"> GUARDA I DETTAGLI </button>

image

image

Is there a button property to change this behavior and making all the button clickable, or it is something I can override in some way via CSS or using another heml structure?

Thank you for time and commitment. Daniele.

massimilianobraglia commented 6 years ago

Hello!

Any news for this one?

lazarljubenovic commented 6 years ago

Looks like it's something to do with these lines:

https://github.com/SparkPost/heml/blob/00fef92c6ab9093ac20c6144214b98175d10025d/packages/heml-elements/src/Button.js#L31-L35

The padding should be applied to the anchor itself, not the wrapping cell data element.