search

SparkPost / matchbox

🔥 A react UI component library
https://design.sparkpost.com
110 stars 10 forks source link

Ability to set marginBottom on LabelValue.Value. #874

Open shrirupa opened 3 years ago

shrirupa commented 3 years ago

🚀 Feature request

Current Behavior

marginBottom cannot be set on LabelValue.Value. So it becomes difficult to handle mocks where the spacing is not default https://sparkpost.invisionapp.com/console/share/ZT2HZ5RVFB/607925652

Desired Behavior

marginBottom can be set on LabelValue.Value

Suggested Solution margin props can be passed to LabelValue.Value

Who does this impact? Who is this for?

To handle mocks where the spacing is not default https://sparkpost.invisionapp.com/console/share/ZT2HZ5RVFB/607925652

jonambas commented 3 years ago

LabelValue accepts margin system props. What's the use case for adding it to LabelValue.Value? Not sure I see where two values are used

shrirupa commented 3 years ago

@jonambas as in the above mocks if the spacing being used between value and label is not the default that matchbox sets, then there isn't a way to adjust that. I think I tried using Stack but that didn't work either.