general feedback - Githubissues

SparkPost / postman-collection

A Postman collection for SparkPost

Apache License 2.0

2 stars 25 forks source link

general feedback #1

Closed nancyhabecker closed 6 years ago

nancyhabecker commented 6 years ago

Here is some feedback I received from @colestrode while he was reviewing my edits to the collection for EU:

Inbound Domains

[x] Update POST body of "Create Inbound Domain" to "inbounddomain.example.com"

Relay Webhooks

[x] Update "Create a Relay Webhook" to use "inbounddomain.example.com" as the domain. This means we can use the inbound domain and relay webhooks collections together.

Sending Domains

[x] the Create endpoint includes a valid public and private key. I'm concerned that might be a security concern; someone may be tempted to re-use those and have their private key be public. I'm thinking if we want to show all the fields, we should make sure those are obviously dummy values. This breaks the convention that all the endpoints should be runnable, but I think in this case that is wise.

tuck1s commented 6 years ago

Great feedback, thanks. Resolved.