search

SparkPost / python-sparkpost

SparkPost client library for Python
https://www.sparkpost.com
Other
92 stars 70 forks source link

_translate_keys in Transmissions should match API #192

Closed duanehutchins closed 5 years ago

duanehutchins commented 5 years ago

The keys sent to transmissions.send() don't match the SparkPost API documentation. Worse, these mismatched keys aren't documented anywhere, so you have to go into the code to trace down the issue.

For example: model['campaign_id'] = kwargs.get('campaign')

It should just use campaign_id to match the API. Better yet, don't qualify the passed data; just send it to the API.

duanehutchins commented 5 years ago

Created PR #193 to fix this issue

duanehutchins commented 5 years ago

PR was merged. Issue resolved.