search

SparkPost / styles

1 stars 0 forks source link

Using default on all variables. #3

Open avigoldman opened 7 years ago

avigoldman commented 7 years ago

It would be really nice to use !default on the variables so that they can be overridden if others cough me cough use this in non-sparkpost related projects.

jonambas commented 7 years ago

Would you prefer the mapped values in config.scss were pulled out into variables first?

avigoldman commented 7 years ago

How would that work?

jonambas commented 7 years ago

We could assign all those values in variables before placing them into the map? Idk if that actually makes any sense ☕️

avigoldman commented 7 years ago

I think we should just let them set the whole map so we don't force them to use our names in the map itself.

jonambas commented 7 years ago

Oh I see, so just default on the entire map

avigoldman commented 7 years ago

yeah, is that the best way to do it?